getsentry / getsentry/sentry-javascript

deno: CI runs one Deno version, and a matrix reference is dead

未关闭
#23,898 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Deno javascript
主要语言
TypeScript
星标
8.7k
派生
1.8k
平均合并
1 天 17 小时
30 天内合并 PR
515

描述

`.github/workflows/build.yml:548`:

```yaml
deno-version: ${{ matrix.deno-version || 'v2.8.3' }}
```

The job has no `strategy: matrix:` block, so `matrix.deno-version` is always empty and the version is always `v2.8.3`. It reads like a matrix that was planned and never wired up.

Related stale note in `dev-packages/deno-integration-tests/suites/orchestrion-mysql/test.ts:19`:

```
// The orchestrion runtime hook only works as a FIRST import inside the entry
// graph in Deno 2.8.0 through 2.8.2.
// TODO: revisit a `--import` or `--preload` approach once Deno 2.8.3 ships.
```

Deno 2.9 is out. The TODO is due.

**Work item.** Either add the matrix the expression expects, or drop the dead `matrix.deno-version ||`. Separately, re-check the `--import` / `--preload` path on 2.9 and update or delete the TODO.
**Prior art ***(related history only)*. No issue. getsentry/sentry-javascript#22790 (merged) set the >= 2.8.3 floor, and getsentry/sentry-javascript#23256 (merged) bumped the `setup-deno` action. Neither touched the dead `matrix.deno-version` expression.

贡献指南

打开贡献指南

调研方向

Start with .github/workflows/build.yml:548 and dev-packages/deno-integration-tests/suites/orchestrion-mysql/test.ts:19. Run the relevant Deno integration job on Deno 2.9 and check the --import/--preload behavior. Done means the workflow no longer has a dead matrix reference and the stale TODO is updated or removed, with the integration tests passing.

由索引模型根据 Issue 内容生成。

评估

技术栈
deno, typescript
领域
ci-cd, testing-qa
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
68/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。