getsentry / getsentry/sentry-javascript

bun default integrations diverge from Node's

オープン 初心者向け
#23,887 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
Bun Feature javascript
主要言語
TypeScript
スター
8.7k
フォーク
1.8k
平均マージ
1日 17時間
マージ済み PR(30日)
523

説明

`packages/bun/src/sdk.ts:48` omits, relative to `node/src/sdk/index.ts:getBaseDefaultIntegrations`:

| Integration | Note |
| -- | -- |
| `conversationIdIntegration` | pure core JS, no Node API. Cloudflare and vercel-edge both include it. Without it, `setConversationId` has no effect on `gen_ai.*` spans under Bun. |
| `systemErrorIntegration` | needs a check |
| `childProcessIntegration` | relies on `child_process` diagnostics channels Bun does not emit (see B1), so probably correct to omit, but say so in a comment |
| `workerThreadsIntegration` | same |

**Work item.** Add `conversationIdIntegration()` to Bun's defaults. For each remaining omission, either add it or leave a one-line comment saying which Bun gap makes it a no-op.

**Prior art ***(tracked)*. [#20237]() (closed, not planned) already settled the `childProcessIntegration` and `workerThreadsIntegration` question, and documents the same root cause as B1: Bun implements the `node:diagnostics_channel` API but never publishes to the `child_process` or `worker_threads` channels. Omitting those two is correct; cite that issue in the comment. Nothing covers `conversationIdIntegration` or `systemErrorIntegration` on Bun.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Compare packages/bun/src/sdk.ts:48 with node/src/sdk/index.ts:getBaseDefaultIntegrations, then review the integration definitions for conversationIdIntegration and systemErrorIntegration. Add the conversation integration, decide the system-error behavior, and document the intentional child-process and worker-thread omissions with a reference to issue #20237; done means Bun's defaults and comments reflect these decisions.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
observability-sre
issue の種類
機能追加
難易度
2/5
見積もり時間
1〜3時間
活発さ
活発
明瞭さ
明確に書かれている
初心者へのやさしさ
84/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。