getsentry / getsentry/sentry-javascript

bun default integrations diverge from Node's

Offen Anfängerfreundlich
#23,887 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Bun Feature javascript
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
515

Beschreibung

`packages/bun/src/sdk.ts:48` omits, relative to `node/src/sdk/index.ts:getBaseDefaultIntegrations`:

| Integration | Note |
| -- | -- |
| `conversationIdIntegration` | pure core JS, no Node API. Cloudflare and vercel-edge both include it. Without it, `setConversationId` has no effect on `gen_ai.*` spans under Bun. |
| `systemErrorIntegration` | needs a check |
| `childProcessIntegration` | relies on `child_process` diagnostics channels Bun does not emit (see B1), so probably correct to omit, but say so in a comment |
| `workerThreadsIntegration` | same |

**Work item.** Add `conversationIdIntegration()` to Bun's defaults. For each remaining omission, either add it or leave a one-line comment saying which Bun gap makes it a no-op.

**Prior art ***(tracked)*. [#20237]() (closed, not planned) already settled the `childProcessIntegration` and `workerThreadsIntegration` question, and documents the same root cause as B1: Bun implements the `node:diagnostics_channel` API but never publishes to the `child_process` or `worker_threads` channels. Omitting those two is correct; cite that issue in the comment. Nothing covers `conversationIdIntegration` or `systemErrorIntegration` on Bun.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Compare packages/bun/src/sdk.ts:48 with node/src/sdk/index.ts:getBaseDefaultIntegrations, then review the integration definitions for conversationIdIntegration and systemErrorIntegration. Add the conversation integration, decide the system-error behavior, and document the intentional child-process and worker-thread omissions with a reference to issue #20237; done means Bun's defaults and comments reflect these decisions.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
observability-sre
Issue-Typ
Feature
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
84/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.