getsentry / getsentry/sentry-javascript
Store metadata on spans separately from attributes
- Ngôn ngữ chính
- TypeScript
- Star
- 8.7k
- Fork
- 1.8k
- Merge trung bình
- 1 ngày 17 giờ
- Pull request đã merge (30 ngày)
- 523
Mô tả
Currently, our SDK stores metadata on spans in attributes that it cleans up before sending them. This isn't ideal, since it happened multiple times that such attributes were still sent because some code path sending spans or transactions didn't perform the cleanup.
Some examples:
- `sentry.sample_rate`
- `sentry.parentIsRemote`
- `sentry.custom_span_name`
It also makes things a bit awkward with sentry conventions. Adding these attributes has no value and they shouldn't be sent anyway.
It's easiest to store this information (which we need at runtime) on a separate field on the span, which never gets serialized to JSON and thus not sent.
This could work like so:
```js
const span = getActiveSpan();
span._metadata = {
sampleRate: 0.99;
}
// or
span.getMetadata().sampleRate = 0.99;
// or
getSpanMetadata(span).sampleRate = 0.99;
```
Which should now be possible, given all spans in the SDK will be ` instanceof SentrySpan` with v11.
Hướng dẫn đóng góp
Hướng nghiên cứu
Start with the getActiveSpan entry point and the SentrySpan implementation, then trace how span metadata is currently stored and serialized to JSON. Done means runtime-only values such as sampleRate, parentIsRemote, and custom_span_name use separate metadata and are never included in serialized spans or transactions.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- typescript
- Lĩnh vực
- observability-sre
- Loại issue
- Tái cấu trúc
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 45/100