getsentry / getsentry/sentry-javascript

Store metadata on spans separately from attributes

Aperta
#22,670 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Feature javascript Spans
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

Currently, our SDK stores metadata on spans in attributes that it cleans up before sending them. This isn't ideal, since it happened multiple times that such attributes were still sent because some code path sending spans or transactions didn't perform the cleanup.

Some examples:
- `sentry.sample_rate`
- `sentry.parentIsRemote`
- `sentry.custom_span_name`

It also makes things a bit awkward with sentry conventions. Adding these attributes has no value and they shouldn't be sent anyway.

It's easiest to store this information (which we need at runtime) on a separate field on the span, which never gets serialized to JSON and thus not sent.

This could work like so:

```js
const span = getActiveSpan();

span._metadata = {
sampleRate: 0.99;
}

// or

span.getMetadata().sampleRate = 0.99;

// or

getSpanMetadata(span).sampleRate = 0.99;
```

Which should now be possible, given all spans in the SDK will be ` instanceof SentrySpan` with v11.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with the getActiveSpan entry point and the SentrySpan implementation, then trace how span metadata is currently stored and serialized to JSON. Done means runtime-only values such as sampleRate, parentIsRemote, and custom_span_name use separate metadata and are never included in serialized spans or transactions.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
observability-sre
Tipo di issue
Refactoring
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.