getsentry / getsentry/sentry-javascript

Ensure Fastify instrumentation sends data expected for name and description inference

オープン
#21,919 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
javascript
主要言語
TypeScript
スター
8.7k
フォーク
1.8k
平均マージ
1日 17時間
マージ済み PR(30日)
515

説明

Right now, Fastify sends data that's largely divergent from other instrumentation:

* op: `hook.fastify` is not registered anywhere, meaning we don't go through the correct span description/name inference rule. I'd propose `function` or `function.fastify` as a replacement.
* It doesn't seem like `middleware` is the correct replacement since Fastify themselves don't refer to hooks as middleware. Middleware could be added via third party dependencies, in which case they should go through our express instrumentation.
* attributes: A [few attributes]() are not registered in sentry conventions and there'd be other, more established hooks that can replace them.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with packages/server-utils/src/integrations/tracing-channel/fastify/instrumentation.ts, especially the operation and attributes referenced in the issue. Compare Fastify's emitted data with Sentry conventions and other instrumentation to determine the appropriate inference inputs. Done means the instrumentation sends registered, consistent data for span name and description inference.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
backend-api-design, observability-sre
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
48/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。