getsentry / getsentry/sentry-javascript

Ensure Fastify instrumentation sends data expected for name and description inference

Offen
#21,919 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
javascript
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
515

Beschreibung

Right now, Fastify sends data that's largely divergent from other instrumentation:

* op: `hook.fastify` is not registered anywhere, meaning we don't go through the correct span description/name inference rule. I'd propose `function` or `function.fastify` as a replacement.
* It doesn't seem like `middleware` is the correct replacement since Fastify themselves don't refer to hooks as middleware. Middleware could be added via third party dependencies, in which case they should go through our express instrumentation.
* attributes: A [few attributes]() are not registered in sentry conventions and there'd be other, more established hooks that can replace them.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with packages/server-utils/src/integrations/tracing-channel/fastify/instrumentation.ts, especially the operation and attributes referenced in the issue. Compare Fastify's emitted data with Sentry conventions and other instrumentation to determine the appropriate inference inputs. Done means the instrumentation sends registered, consistent data for span name and description inference.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
backend-api-design, observability-sre
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.