getsentry / getsentry/sentry-javascript

Extension of shouldCreateSpanForRequest to cover usual cases

Aperta
#10,638 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Improvement Node.js
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
515

Descrizione

### Problem Statement

Right now the `shouldCreateSpanForRequest` callback could be helpful to distinguish between API endpoints and decide whether a request should be decorated with the distributed tracing headers. Besides just having the URL at hand to make a decision, it would be helpful to provide some more request specific information – especially the HTTP method. That would help to only send the tracing headers to API methods that could deal with those.

### Solution Brainstorm

Extend the `shouldCreateSpanForRequest` by an additional parameter providing at least the HTTP method.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.