getsentry / getsentry/sentry-javascript

Extension of shouldCreateSpanForRequest to cover usual cases

Ouverte
#10,638 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Improvement Node.js
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
515

Description

### Problem Statement

Right now the `shouldCreateSpanForRequest` callback could be helpful to distinguish between API endpoints and decide whether a request should be decorated with the distributed tracing headers. Besides just having the URL at hand to make a decision, it would be helpful to provide some more request specific information – especially the HTTP method. That would help to only send the tracing headers to API methods that could deal with those.

### Solution Brainstorm

Extend the `shouldCreateSpanForRequest` by an additional parameter providing at least the HTTP method.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.