getsentry / getsentry/sentry-javascript

Extension of shouldCreateSpanForRequest to cover usual cases

Abierto
#10,638 1 comentario 0 reacciones 0 asignados Ver en GitHub
Improvement Node.js
Lenguaje dominante
TypeScript
Estrellas
8.7k
Forks
1.8k
Merge medio
1 d 17 h
PR fusionados (30 d)
515

Descripción

### Problem Statement

Right now the `shouldCreateSpanForRequest` callback could be helpful to distinguish between API endpoints and decide whether a request should be decorated with the distributed tracing headers. Besides just having the URL at hand to make a decision, it would be helpful to provide some more request specific information – especially the HTTP method. That would help to only send the tracing headers to API methods that could deal with those.

### Solution Brainstorm

Extend the `shouldCreateSpanForRequest` by an additional parameter providing at least the HTTP method.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.