getsentry / getsentry/sentry-java

Ok Http Retry Tracking using the EventListner API?

Open
#4,161 2 comments 0 reactions 0 assignees View on GitHub
Android Improvement Spans
Dominant language
Kotlin
Stars
1.4k
Forks
478
Avg merge
2d 23h
Merged PRs (30d)
67

Description

### Description

Hello Team, I have a question about how we are tracking the network metrics using the OkHttp EventListenerAPI here - https://github.com/getsentry/sentry-java/blob/main/sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpEventListener.kt

From my understanding, with the current implementation, if a request is retried, the event listener only captures metrics for the latest attempt and does not track metrics for each retry separately. So, if there are three requests (one original and two retries), we only see metrics for the last one. I understand that some metrics, like CONNECT, SSL, and DNS, would only be recorded for the initial request since OkHttp reuses the connection. However, other metrics could still be relevant for retries.

Was there a specific reason for implementing it this way?

Looking forward to your insights!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.