getsentry / getsentry/sentry-java

Normalize `release` option

Ouverte
#3,700 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Android Improvement
Langage dominant
Kotlin
Étoiles
1.4k
Forks
478
Merge moyen
2 j 23 h
PR mergées (30 j)
67

Description

### Description

Currently we read out the `versionName` as-is, but the customer can set any random string in there, which will break our release health feature (and everything around releases in general). So we should try to normalize the `versionName` to comply with SemVer (e.g. relax the semver regex by excluding a prepending `v` for example, if the version was set to `v1.2.3`).

If the version is still not a valid semver after normalization, we should fail/print a warning and let the customer know that the release feature won't be working correctly in some cases.

Related to:
* https://github.com/getsentry/sentry/issues/76502

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.