getsentry / getsentry/sentry-java

Normalize `release` option

Abierto
#3,700 1 comentario 0 reacciones 0 asignados Ver en GitHub
Android Improvement
Lenguaje dominante
Kotlin
Estrellas
1.4k
Forks
478
Merge medio
2 d 23 h
PR fusionados (30 d)
67

Descripción

### Description

Currently we read out the `versionName` as-is, but the customer can set any random string in there, which will break our release health feature (and everything around releases in general). So we should try to normalize the `versionName` to comply with SemVer (e.g. relax the semver regex by excluding a prepending `v` for example, if the version was set to `v1.2.3`).

If the version is still not a valid semver after normalization, we should fail/print a warning and let the customer know that the release feature won't be working correctly in some cases.

Related to:
* https://github.com/getsentry/sentry/issues/76502

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.