getsentry / getsentry/sentry-java

Normalize `release` option

Offen
#3,700 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Android Improvement
Vorherrschende Sprache
Kotlin
Sterne
1.4k
Forks
478
Ø Merge
2 T. 23 Std.
Gemergte PRs (30 T.)
67

Beschreibung

### Description

Currently we read out the `versionName` as-is, but the customer can set any random string in there, which will break our release health feature (and everything around releases in general). So we should try to normalize the `versionName` to comply with SemVer (e.g. relax the semver regex by excluding a prepending `v` for example, if the version was set to `v1.2.3`).

If the version is still not a valid semver after normalization, we should fail/print a warning and let the customer know that the release feature won't be working correctly in some cases.

Related to:
* https://github.com/getsentry/sentry/issues/76502

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.