gbdev / gbdev/gb-asm-tutorial

Changing the term "keys" in input routine

Open
#72 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Assembly
Stars
179
Forks
64
Avg merge
7d 22h
Merged PRs (30d)
1

Description

I wonder if a more console-focused term such as "buttons" could be used instead of "keys" for the following-
- UpdateKeys
- wCurKeys
- wNewKeys

From what I can tell the comments in the code itself uses the word "buttons" and "directions" to refer to the face buttons and d-pad and that "keys" are meant to encompass both of these but I still feel like it's a word not quite suited for the purpose.

Contributor guide

Open the contributing guide

Research direction

Search the codebase for UpdateKeys, wCurKeys, and wNewKeys, then read the nearby comments describing buttons and directions. Check every reference to determine whether the terminology can be changed consistently; done means the names and related comments use the agreed term without breaking references.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.