funcool / funcool/clojure.jdbc
Close connections when using a datasource directly, or don't let it be used directly.
- 主要言語
- Clojure
- スター
- 106
- フォーク
- 23
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
javax.sql.DataSource implements the proto/IConnection protocol, but it's difficult to see how directly using it like that is anything but a misfeature. This protocol implementation lets you do the following:
`(jdbc/fetch datasource "select whatever from whatever;")`
If you do this, the connection that gets created will never get closed. You need to wrap the whole thing in a with-open, jdbc/connection like this:
```
(with-open [conn (jdbc/connection datasource)]
(jdbc/fetch conn "select whatever from whatever;"))
```
Seeing as how the first snippet is always a bad idea, it shouldn't be possible to write the first and have it succeed at all. If we're supposed to go through the connection wrapper jdbc/connection, then the api should force us to do exactly that and not silently succeed when misused.
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
評価
この issue はまだ評価されていません。