funcool / funcool/clojure.jdbc

Close connections when using a datasource directly, or don't let it be used directly.

未关闭
#38 0 条评论 4 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Clojure
星标
106
派生
23
PR 合并指标
30 天内没有已合并 PR

描述

javax.sql.DataSource implements the proto/IConnection protocol, but it's difficult to see how directly using it like that is anything but a misfeature. This protocol implementation lets you do the following:

`(jdbc/fetch datasource "select whatever from whatever;")`

If you do this, the connection that gets created will never get closed. You need to wrap the whole thing in a with-open, jdbc/connection like this:

```
(with-open [conn (jdbc/connection datasource)]
(jdbc/fetch conn "select whatever from whatever;"))
```

Seeing as how the first snippet is always a bad idea, it shouldn't be possible to write the first and have it succeed at all. If we're supposed to go through the connection wrapper jdbc/connection, then the api should force us to do exactly that and not silently succeed when misused.

贡献指南

这个仓库没有索引到贡献指南

调研方向

从 issue 中描述的 javax.sql.DataSource 对应的 proto/IConnection 实现以及 jdbc/fetch 和 jdbc/connection 入口点开始。将直接使用 datasource 的示例与使用 with-open 连接的示例进行比较;完成意味着直接使用不再泄漏连接或被拒绝,同时包装形式继续正常工作。

由索引模型根据 Issue 内容生成。

评估

技术栈
clojure
领域
databases
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。