Refactor `cpu_profile_model` to prevent side effects
オープン
P3
screen: cpu profiler
- 主要言語
- Dart
- スター
- 1.7k
- フォーク
- 404
- 平均マージ
- 6日 17時間
- マージ済み PR（30日）
- 18
説明
The functions called in `generateFromCpuSamples` must be called in that particular order. This is because of function side effects:
1. Generating the stack frames both creates the timeline tree and assigns frame IDs to every node in the tree
2. Creating the sample events expects that the tree has already been created, and that the frame IDs have been assigned to every node
Ideally we should refactor the code so that we aren't dependent on hidden side effects.
コントリビューションガイド
評価
この issue はまだ評価されていません。