flutter / flutter/devtools

Refactor `cpu_profile_model` to prevent side effects

Ouverte
#9,353 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
P3 screen: cpu profiler
Langage dominant
Dart
Étoiles
1.7k
Forks
404
Merge moyen
6 j 17 h
PR mergées (30 j)
18

Description

The functions called in `generateFromCpuSamples` must be called in that particular order. This is because of function side effects:

1. Generating the stack frames both creates the timeline tree and assigns frame IDs to every node in the tree
2. Creating the sample events expects that the tree has already been created, and that the frame IDs have been assigned to every node

Ideally we should refactor the code so that we aren't dependent on hidden side effects.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.