Upgrading to latest perfetto build caused severe performance regression
- Ngôn ngữ chính
- Dart
- Star
- 1.7k
- Fork
- 404
- Merge trung bình
- 6 ngày 17 giờ
- Pull request đã merge (30 ngày)
- 18
Mô tả
Culprit that caused the regression: https://github.com/flutter/devtools/pull/7445
After speaking with @stevegolton on the Perfetto team, the hypothesis is that this was caused by plugin initialization added in https://github.com/google/perfetto/commit/24a0d91beab59e22c1f1e0d720e3cdb417796f55 (first included in v36.0).
Immediate action:
- [ ] Roll back our perfetto build to avoid the regression.
- EDIT: I was able to use [v34.0](https://github.com/google/perfetto/releases/tag/v34.0) with a local patch to include https://android-review.git.corp.google.com/c/platform/external/perfetto/+/3015413
- see https://github.com/flutter/devtools/pull/7480
Longer term action:
- work with the Perfetto team to see if we can avoid expensive initialization on each trace load.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.