flutter / flutter/devtools

Upgrading to latest perfetto build caused severe performance regression

Offen
#7,477 1 Kommentar 1 Reaktion 1 zugewiesene Person Beansprucht von @kenzieschmoll Auf GitHub ansehen
P1 performance > perfetto screen: performance tech debt
Vorherrschende Sprache
Dart
Sterne
1.7k
Forks
404
Ø Merge
6 T. 17 Std.
Gemergte PRs (30 T.)
18

Beschreibung

Culprit that caused the regression: https://github.com/flutter/devtools/pull/7445

After speaking with @stevegolton on the Perfetto team, the hypothesis is that this was caused by plugin initialization added in https://github.com/google/perfetto/commit/24a0d91beab59e22c1f1e0d720e3cdb417796f55 (first included in v36.0).

Immediate action:
- [ ] Roll back our perfetto build to avoid the regression.
- EDIT: I was able to use [v34.0](https://github.com/google/perfetto/releases/tag/v34.0) with a local patch to include https://android-review.git.corp.google.com/c/platform/external/perfetto/+/3015413
- see https://github.com/flutter/devtools/pull/7480

Longer term action:
- work with the Perfetto team to see if we can avoid expensive initialization on each trace load.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.