flutter / flutter/devtools

"frame times may be negatively affected" is not quite the right message

オープン
#3,530 コメント 9 件 リアクション 0 件 担当者 0 名 GitHub で見る
needs discussion P3 polish screen: performance
主要言語
Dart
スター
1.7k
フォーク
404
平均マージ
6日 17時間
マージ済み PR(30日)
18

説明

We have these checkboxes that add more instrumentation:
https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/performance/performance_screen.dart#L389

We have a message that says that "frame times may be negatively affected" when these are on, which is true. However, I'm not sure that fully represents the issue with these flags. People might see that and think, ok, I'll ignore the _numbers_, but the _relative_ sizes of work loads is still a guide as to what I should work on... which is wrong. It's possible for a widget to take 5ms with these flags off, and be the main problem that causes jank, but for these flags to cause other widgets to take 5ms as well while the problematic widget continues to only take 5ms, and now the source of the jank has been obscured.

The problem is that the frame times can be affected in _non-representative ways_.

Anyway I tried to submit a PR to fix this but I could not come up with wording that was accurate and comprehensible. So I'm filing this bug instead.

cc @InMatrix

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Inspect packages/devtools_app/lib/src/performance/performance_screen.dart around the instrumentation checkboxes and the existing "frame times may be negatively affected" message. Refine the wording so users understand that instrumentation can distort frame workloads in non-representative ways, including relative comparisons, then verify the message in the performance screen.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
dart
領域
performance, tooling
issue の種類
バグ
難易度
2/5
見積もり時間
1〜3時間
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。