flutter / flutter/devtools

"frame times may be negatively affected" is not quite the right message

Ouverte
#3,530 9 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
needs discussion P3 polish screen: performance
Langage dominant
Dart
Étoiles
1.7k
Forks
404
Merge moyen
6 j 17 h
PR mergées (30 j)
18

Description

We have these checkboxes that add more instrumentation:
https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/performance/performance_screen.dart#L389

We have a message that says that "frame times may be negatively affected" when these are on, which is true. However, I'm not sure that fully represents the issue with these flags. People might see that and think, ok, I'll ignore the _numbers_, but the _relative_ sizes of work loads is still a guide as to what I should work on... which is wrong. It's possible for a widget to take 5ms with these flags off, and be the main problem that causes jank, but for these flags to cause other widgets to take 5ms as well while the problematic widget continues to only take 5ms, and now the source of the jank has been obscured.

The problem is that the frame times can be affected in _non-representative ways_.

Anyway I tried to submit a PR to fix this but I could not come up with wording that was accurate and comprehensible. So I'm filing this bug instead.

cc @InMatrix

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Inspect packages/devtools_app/lib/src/performance/performance_screen.dart around the instrumentation checkboxes and the existing "frame times may be negatively affected" message. Refine the wording so users understand that instrumentation can distort frame workloads in non-representative ways, including relative comparisons, then verify the message in the performance screen.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
dart
Domaine
performance, tooling
Type d'issue
Bug
Difficulté
2/5
Temps estimé
1-3 heures
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.