firebase / firebase/firebase-admin-node

[FR] Add test for "must not exceed the maximum of 4 weeks"

未关闭
#2,832 1 条评论 0 个 reaction 已指派 1 人 已被 @chong-shao 认领 在 GitHub 查看
api: messaging type: feature request
主要语言
TypeScript
星标
1.7k
派生
419
平均合并
3 天 10 小时
30 天内合并 PR
16

描述

**Is your feature request related to a problem? Please describe.**
When inserting a pushnotification, its TTL may not exceed 4 weeks according to docs.
This is only checked after the request is send to the API. It should be checked in the library, to easier catch bugs and not annoy the API.

**Describe the solution you'd like**
Check the payload TTL locally (in the library) for common mistakes.

**Describe alternatives you've considered**
Right now its done to the enduser of checking this. And the results may vary. In the end it can happend due to bugs or other things that invalid payloads still get send to the API - when this library could've prevented that.

Thanks for consideration.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。