firebase / firebase/firebase-admin-node

[FR] Add test for "must not exceed the maximum of 4 weeks"

Ouverte
#2,832 1 commentaire 0 réactions 1 personne assignée Réclamée par @chong-shao Voir sur GitHub
api: messaging type: feature request
Langage dominant
TypeScript
Étoiles
1.7k
Forks
419
Merge moyen
3 j 10 h
PR mergées (30 j)
16

Description

**Is your feature request related to a problem? Please describe.**
When inserting a pushnotification, its TTL may not exceed 4 weeks according to docs.
This is only checked after the request is send to the API. It should be checked in the library, to easier catch bugs and not annoy the API.

**Describe the solution you'd like**
Check the payload TTL locally (in the library) for common mistakes.

**Describe alternatives you've considered**
Right now its done to the enduser of checking this. And the results may vary. In the end it can happend due to bugs or other things that invalid payloads still get send to the API - when this library could've prevented that.

Thanks for consideration.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.