firebase / firebase/firebase-admin-node

[FR] Add test for "must not exceed the maximum of 4 weeks"

Offen
#2,832 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @chong-shao Auf GitHub ansehen
api: messaging type: feature request
Vorherrschende Sprache
TypeScript
Sterne
1.7k
Forks
419
Ø Merge
3 T. 10 Std.
Gemergte PRs (30 T.)
16

Beschreibung

**Is your feature request related to a problem? Please describe.**
When inserting a pushnotification, its TTL may not exceed 4 weeks according to docs.
This is only checked after the request is send to the API. It should be checked in the library, to easier catch bugs and not annoy the API.

**Describe the solution you'd like**
Check the payload TTL locally (in the library) for common mistakes.

**Describe alternatives you've considered**
Right now its done to the enduser of checking this. And the results may vary. In the end it can happend due to bugs or other things that invalid payloads still get send to the API - when this library could've prevented that.

Thanks for consideration.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.