firebase / firebase/firebase-admin-node

Why isn't the response of FunctionsApiClient.enqueue returned?

Đang mở
#2,791 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
api: functions
Ngôn ngữ chính
TypeScript
Star
1.7k
Fork
419
Merge trung bình
3 ngày 10 giờ
Pull request đã merge (30 ngày)
16

Mô tả

Here:

https://github.com/firebase/firebase-admin-node/blame/83585498d9bd48b9ba715a882a3b9c951ca8422d/src/functions/functions-api-client-internal.ts#L162

```
await this.httpClient.send(request)
```

Or better yet, actually check it, type it, and return it, like the google-cloud library

https://cloud.google.com/nodejs/docs/reference/tasks/latest/tasks/v2.cloudtasksclient#_google_cloud_tasks_v2_CloudTasksClient_createTask_member_1_

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/0469e1fbf20906aaef01e17b0274c79a0725b9a4/cloud-tasks/snippets/createTask.js#L77

The feat that included this option last year seemed to mention this too. Obviously that's not yet done, and is probably a load of work, so, for the moment, it'd be great if just the response of that is returned, and we can work with that.

Reason I need this is to be able to refer to a created task, to be able to delete it later (functionality I'd also love was added here) - I'd prefer to be able to edit it, specifically the scheduleTime, but that functionality doesn't seem to be available from cloud tasks.

I'm happy to submit a PR returning the response, but wanted to open this issue first, as adding that as a PR would likely get rejected out of hand.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.