firebase / firebase/firebase-admin-node

Why isn't the response of FunctionsApiClient.enqueue returned?

未关闭
#2,791 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
api: functions
主要语言
TypeScript
星标
1.7k
派生
419
平均合并
3 天 10 小时
30 天内合并 PR
16

描述

Here:

https://github.com/firebase/firebase-admin-node/blame/83585498d9bd48b9ba715a882a3b9c951ca8422d/src/functions/functions-api-client-internal.ts#L162

```
await this.httpClient.send(request)
```

Or better yet, actually check it, type it, and return it, like the google-cloud library

https://cloud.google.com/nodejs/docs/reference/tasks/latest/tasks/v2.cloudtasksclient#_google_cloud_tasks_v2_CloudTasksClient_createTask_member_1_

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/0469e1fbf20906aaef01e17b0274c79a0725b9a4/cloud-tasks/snippets/createTask.js#L77

The feat that included this option last year seemed to mention this too. Obviously that's not yet done, and is probably a load of work, so, for the moment, it'd be great if just the response of that is returned, and we can work with that.

Reason I need this is to be able to refer to a created task, to be able to delete it later (functionality I'd also love was added here) - I'd prefer to be able to edit it, specifically the scheduleTime, but that functionality doesn't seem to be available from cloud tasks.

I'm happy to submit a PR returning the response, but wanted to open this issue first, as adding that as a PR would likely get rejected out of hand.

贡献指南

打开贡献指南

调研方向

从 src/functions/functions-api-client-internal.ts 中引用的行开始,将所请求的行为与链接的 Cloud Tasks 客户端文档和示例进行比较。检查现有的 FunctionsApiClient.enqueue 契约和测试覆盖率,然后验证成功的 enqueue 会向调用方公开所创建 task 的响应。

由索引模型根据 Issue 内容生成。

评估

技术栈
google-cloud, nodejs, typescript
领域
api, backend
Issue 类型
功能
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。