firebase / firebase/firebase-admin-java

FirebaseMessaging.sendEach has a limit of 500 messages

未关闭
#1,103 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
api: messaging type: feature request
主要语言
Java
星标
620
派生
305
平均合并
3 小时 23 分钟
30 天内合并 PR
1

描述

### [READ] Step 1: Are you in the right place?

* For issues or feature requests related to __the code in this repository__
file a Github issue.
* If this is a __feature request__ make sure the issue title starts with "FR:".
* For general technical questions, post a question on [StackOverflow](http://stackoverflow.com/)
with the firebase tag.
* For general Firebase discussion, use the [firebase-talk](https://groups.google.com/forum/#!forum/firebase-talk)
google group.
* For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
[Firebase support channel](https://firebase.google.com/support/).

Read and understood.

### [REQUIRED] Step 2: Describe your environment

* Operating System version: N/A
* Firebase SDK version: 9.4.2
* Library version: _____
* Firebase Product: messaging (auth, database, storage, etc)

### [REQUIRED] Step 3: Describe the problem

sendEach has a limit of 500 messages, this limit is probably a leftover from sendAll which no longer works. It's not really logical to have this limit anymore.

https://github.com/firebase/firebase-admin-java/blob/master/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java#L226

#### Steps to reproduce:

Create a list with over 500 messages / push notifications. Call FirebaseMessaging.sendEach with the list. An error is thrown that there is over 500 messages in the array.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

#### Relevant Code:

```
checkArgument(immutableMessages.size() <= 500,
"messages list must not contain more than 500 elements");
```
https://github.com/firebase/firebase-admin-java/blob/master/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java#L226

贡献指南

打开贡献指南

调研方向

Inspect src/main/java/com/google/firebase/messaging/FirebaseMessaging.java around line 226, starting with the validation applied by FirebaseMessaging.sendEach. Confirm whether the 500-message restriction still applies, then locate the relevant tests and update them so completion is demonstrated by handling a list larger than 500 without that validation error.

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
api, backend
Issue 类型
功能
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。