firebase / firebase/firebase-admin-java

FirebaseMessaging.sendEach has a limit of 500 messages

Open
#1,103 0 comments 0 reactions 0 assignees View on GitHub
api: messaging type: feature request
Dominant language
Java
Stars
620
Forks
305
Avg merge
3h 23m
Merged PRs (30d)
1

Description

### [READ] Step 1: Are you in the right place?

* For issues or feature requests related to __the code in this repository__
file a Github issue.
* If this is a __feature request__ make sure the issue title starts with "FR:".
* For general technical questions, post a question on [StackOverflow](http://stackoverflow.com/)
with the firebase tag.
* For general Firebase discussion, use the [firebase-talk](https://groups.google.com/forum/#!forum/firebase-talk)
google group.
* For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
[Firebase support channel](https://firebase.google.com/support/).

Read and understood.

### [REQUIRED] Step 2: Describe your environment

* Operating System version: N/A
* Firebase SDK version: 9.4.2
* Library version: _____
* Firebase Product: messaging (auth, database, storage, etc)

### [REQUIRED] Step 3: Describe the problem

sendEach has a limit of 500 messages, this limit is probably a leftover from sendAll which no longer works. It's not really logical to have this limit anymore.

https://github.com/firebase/firebase-admin-java/blob/master/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java#L226

#### Steps to reproduce:

Create a list with over 500 messages / push notifications. Call FirebaseMessaging.sendEach with the list. An error is thrown that there is over 500 messages in the array.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

#### Relevant Code:

```
checkArgument(immutableMessages.size() <= 500,
"messages list must not contain more than 500 elements");
```
https://github.com/firebase/firebase-admin-java/blob/master/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java#L226

Contributor guide

Open the contributing guide

Research direction

Inspect src/main/java/com/google/firebase/messaging/FirebaseMessaging.java around line 226, starting with the validation applied by FirebaseMessaging.sendEach. Confirm whether the 500-message restriction still applies, then locate the relevant tests and update them so completion is demonstrated by handling a list larger than 500 without that validation error.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.