firebase / firebase/firebase-admin-java

FirebaseMessaging.sendEach has a limit of 500 messages

Aberta
#1,103 0 comentários 0 reações 0 responsáveis Ver no GitHub
api: messaging type: feature request
Linguagem predominante
Java
Estrelas
620
Forks
305
Merge médio
3h 23min
PRs com merge (30d)
1

Descrição

### [READ] Step 1: Are you in the right place?

* For issues or feature requests related to __the code in this repository__
file a Github issue.
* If this is a __feature request__ make sure the issue title starts with "FR:".
* For general technical questions, post a question on [StackOverflow](http://stackoverflow.com/)
with the firebase tag.
* For general Firebase discussion, use the [firebase-talk](https://groups.google.com/forum/#!forum/firebase-talk)
google group.
* For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
[Firebase support channel](https://firebase.google.com/support/).

Read and understood.

### [REQUIRED] Step 2: Describe your environment

* Operating System version: N/A
* Firebase SDK version: 9.4.2
* Library version: _____
* Firebase Product: messaging (auth, database, storage, etc)

### [REQUIRED] Step 3: Describe the problem

sendEach has a limit of 500 messages, this limit is probably a leftover from sendAll which no longer works. It's not really logical to have this limit anymore.

https://github.com/firebase/firebase-admin-java/blob/master/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java#L226

#### Steps to reproduce:

Create a list with over 500 messages / push notifications. Call FirebaseMessaging.sendEach with the list. An error is thrown that there is over 500 messages in the array.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

#### Relevant Code:

```
checkArgument(immutableMessages.size() <= 500,
"messages list must not contain more than 500 elements");
```
https://github.com/firebase/firebase-admin-java/blob/master/src/main/java/com/google/firebase/messaging/FirebaseMessaging.java#L226

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Inspect src/main/java/com/google/firebase/messaging/FirebaseMessaging.java around line 226, starting with the validation applied by FirebaseMessaging.sendEach. Confirm whether the 500-message restriction still applies, then locate the relevant tests and update them so completion is demonstrated by handling a list larger than 500 without that validation error.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
java
Domínio
api, backend
Tipo de issue
Funcionalidade
Dificuldade
3/5
Tempo estimado
1-2 dias
Status de atividade
Estagnada
Clareza
Claramente especificada
Facilidade para iniciantes
45/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.