ferdynton / ferdynton/unique_thread

Eliminate `sleep` calls from tests

未关闭
#2 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
to do
主要语言
Ruby
星标
2
派生
2
PR 合并指标
30 天内没有已合并 PR

描述

The unit tests currently use a few calls to `sleep` with very small waits in order to give control to the thread.

These calls don't hurt "much" to the test time because the few tests we have run in a couple seconds anyway. However, it probably is a smell of a lack of understanding of how we interface with the gem.

For example, if the gem was a regular `Thread`, the proper way of handling control to it would be to `wait`. However, the gem it's not really a thread, so this is not possible.

The point of this task is to go in that direction: think (and implement) a way to test `UniqueThread` in a similar way that one would deal with a regular `Thread`

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。