ferdynton / ferdynton/unique_thread

Eliminate `sleep` calls from tests

Aperta
#2 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
to do
Lingua principale
Ruby
Stelle
2
Fork
2
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The unit tests currently use a few calls to `sleep` with very small waits in order to give control to the thread.

These calls don't hurt "much" to the test time because the few tests we have run in a couple seconds anyway. However, it probably is a smell of a lack of understanding of how we interface with the gem.

For example, if the gem was a regular `Thread`, the proper way of handling control to it would be to `wait`. However, the gem it's not really a thread, so this is not possible.

The point of this task is to go in that direction: think (and implement) a way to test `UniqueThread` in a similar way that one would deal with a regular `Thread`

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.