ferdynton / ferdynton/unique_thread

Eliminate `sleep` calls from tests

Offen
#2 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
to do
Vorherrschende Sprache
Ruby
Sterne
2
Forks
2
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

The unit tests currently use a few calls to `sleep` with very small waits in order to give control to the thread.

These calls don't hurt "much" to the test time because the few tests we have run in a couple seconds anyway. However, it probably is a smell of a lack of understanding of how we interface with the gem.

For example, if the gem was a regular `Thread`, the proper way of handling control to it would be to `wait`. However, the gem it's not really a thread, so this is not possible.

The point of this task is to go in that direction: think (and implement) a way to test `UniqueThread` in a similar way that one would deal with a regular `Thread`

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.