felangel / felangel/mason

Consider renaming Logger

Đang mở
#584 8 bình luận 2 reaction 1 người được giao Được @felangel nhận Xem trên GitHub
enhancement candidate question waiting for response
Ngôn ngữ chính
Dart
Star
1.1k
Fork
113
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Mason might have too many users already to do anything about this , but I thought I'd point this out.

The term "Logger" appears to be used within the context of hooks to interact with a user. This is a very confusing name. I don't think I've ever seen the term "logger" applied to user interaction. It would never have occurred to me to look at the `Logger` API to control user input, except that I saw some other source code that was using it for that purpose.

Typically, logging is the passive accumulation of information during execution. Logs might print to stdout, or maybe not. But either way, it's information gathering.

User interaction is a two-way exchange with lots of blocking in between. The goals of this user interaction is very different than that of logging, and loggers would never dream of blocking execution to wait for a response.

You might consider adjusting the associated API names, so that Mason developers know where to go for traditional logging, and where to go for a console-based user interface.

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.