felangel / felangel/mason

Consider renaming Logger

Abierto
#584 8 comentarios 2 reacciones 1 asignado Reclamado por @felangel Ver en GitHub
enhancement candidate question waiting for response
Lenguaje dominante
Dart
Estrellas
1.1k
Forks
113
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Mason might have too many users already to do anything about this , but I thought I'd point this out.

The term "Logger" appears to be used within the context of hooks to interact with a user. This is a very confusing name. I don't think I've ever seen the term "logger" applied to user interaction. It would never have occurred to me to look at the `Logger` API to control user input, except that I saw some other source code that was using it for that purpose.

Typically, logging is the passive accumulation of information during execution. Logs might print to stdout, or maybe not. But either way, it's information gathering.

User interaction is a two-way exchange with lots of blocking in between. The goals of this user interaction is very different than that of logging, and loggers would never dream of blocking execution to wait for a response.

You might consider adjusting the associated API names, so that Mason developers know where to go for traditional logging, and where to go for a console-based user interface.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.