facebook / facebook/duckling

Arabic regex match some parts of words that mustn't be matched

オープン
#131 コメント 4 件 リアクション 5 件 担当者 0 名 GitHub で見る
bug help wanted
主要言語
Haskell
スター
4.3k
フォーク
740
PR マージ指標
30日以内にマージされた PR はありません

説明

In some Arabic dimensions, the regex doesn't match whole words only, instead it sometimes match some part of the word that mustn't be matched at all ! which makes serious buggy outputs.
I noticed this problem in the following dimensions:
1- ordinal
2- number
3- time
4- duration

for example:
if the input text was:
"وأحدث ذلك مشكلة كبيرة"
which in English means:
"And that made a big problem"

Duckling match the word "احد" (which means "Sunday") from its built-in regex, with the word "وأحدث" (which means "made") from the input text ! (see the following photo for run time)
![time bug](https://user-images.githubusercontent.com/26072899/34329631-b0f0826c-e910-11e7-9b48-d50159770365.JPG)

this was in "time" dimension.

examples for the other dimensions are also attached:

a- "ordinal" dimension:
![ordinal bug](https://user-images.githubusercontent.com/26072899/34329667-cb6a9b68-e911-11e7-9c9f-cf0c48b12f8d.JPG)

b- "number" dimension:
This example shows bugs in more the one dimension, number dim is one of them.
![number bug](https://user-images.githubusercontent.com/26072899/34329720-a44c3288-e913-11e7-89b1-e6dcc8405d56.JPG)

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。