facebook / facebook/duckling

Arabic regex match some parts of words that mustn't be matched

Abierto
#131 4 comentarios 5 reacciones 0 asignados Ver en GitHub
bug help wanted
Lenguaje dominante
Haskell
Estrellas
4.3k
Forks
740
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In some Arabic dimensions, the regex doesn't match whole words only, instead it sometimes match some part of the word that mustn't be matched at all ! which makes serious buggy outputs.
I noticed this problem in the following dimensions:
1- ordinal
2- number
3- time
4- duration

for example:
if the input text was:
"وأحدث ذلك مشكلة كبيرة"
which in English means:
"And that made a big problem"

Duckling match the word "احد" (which means "Sunday") from its built-in regex, with the word "وأحدث" (which means "made") from the input text ! (see the following photo for run time)
![time bug](https://user-images.githubusercontent.com/26072899/34329631-b0f0826c-e910-11e7-9b48-d50159770365.JPG)

this was in "time" dimension.

examples for the other dimensions are also attached:

a- "ordinal" dimension:
![ordinal bug](https://user-images.githubusercontent.com/26072899/34329667-cb6a9b68-e911-11e7-9c9f-cf0c48b12f8d.JPG)

b- "number" dimension:
This example shows bugs in more the one dimension, number dim is one of them.
![number bug](https://user-images.githubusercontent.com/26072899/34329720-a44c3288-e913-11e7-89b1-e6dcc8405d56.JPG)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.