facebook / facebook/docusaurus

Better SVGR / SVGO default configs

オープン
#10,679 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る
proposal
主要言語
TypeScript
スター
66.2k
フォーク
10k
平均マージ
1日 3時間
マージ済み PR(30日)
52

説明

### Motivation

If you are an SVGR / SVGO expert, please help us find better defaults.

In https://github.com/facebook/docusaurus/pull/10677 we are creating a new `@docusaurus/plugin-svgr` plugin that you can now configure through plugin/preset options.

This plugin moves this core feature to a dedicated plugin:

```jsx
import DocusaurusSvg from './docusaurus.svg';

;
```

https://docusaurus.io/docs/markdown-features/assets#inline-svgs

This offers you escape hatches for when the default SVGR / SVGO config does not fit your needs.

But we'd still like to improve the Docusaurus SVGR / SVGO default configs

These configs define how you import and use SVG files in your React code, and changing those can break or fix existing sites by altering what gets rendered and how SVG components are converted to React components.

This would be a breaking change in an upcoming major version of Docusaurus (v4 for example).

We'd like to find defaults that work well for most sites and reduce the need for users to customize those configs. Optimizations should rather be safe and avoid potential SVG ids/class/whatever conflicts.

## Current configs

These are the historical configs we use in Docusaurus v3:

```ts
const DefaultSVGOConfig: SVGOConfig = {
plugins: [
{
name: 'preset-default',
params: {
overrides: {
removeTitle: false,
removeViewBox: false,
},
},
},
],
};

const DefaultSVGRConfig: SVGRConfig = {
prettier: false,
svgo: true,
svgoConfig: DefaultSVGOConfig,
titleProp: true,
};
```

## Related links

- https://github.com/facebook/docusaurus/issues/8297
- https://github.com/facebook/docusaurus/issues/10636
- https://github.com/facebook/docusaurus/pull/10205
- https://github.com/facebook/docusaurus/pull/10211
- https://github.com/facebook/docusaurus/pull/10677

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。