facebook / facebook/docusaurus

Better SVGR / SVGO default configs

Aperta
#10,679 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
proposal
Lingua principale
TypeScript
Stelle
66.2k
Fork
10k
Merge medio
1g 3h
PR unite (30g)
52

Descrizione

### Motivation

If you are an SVGR / SVGO expert, please help us find better defaults.

In https://github.com/facebook/docusaurus/pull/10677 we are creating a new `@docusaurus/plugin-svgr` plugin that you can now configure through plugin/preset options.

This plugin moves this core feature to a dedicated plugin:

```jsx
import DocusaurusSvg from './docusaurus.svg';

;
```

https://docusaurus.io/docs/markdown-features/assets#inline-svgs

This offers you escape hatches for when the default SVGR / SVGO config does not fit your needs.

But we'd still like to improve the Docusaurus SVGR / SVGO default configs

These configs define how you import and use SVG files in your React code, and changing those can break or fix existing sites by altering what gets rendered and how SVG components are converted to React components.

This would be a breaking change in an upcoming major version of Docusaurus (v4 for example).

We'd like to find defaults that work well for most sites and reduce the need for users to customize those configs. Optimizations should rather be safe and avoid potential SVG ids/class/whatever conflicts.

## Current configs

These are the historical configs we use in Docusaurus v3:

```ts
const DefaultSVGOConfig: SVGOConfig = {
plugins: [
{
name: 'preset-default',
params: {
overrides: {
removeTitle: false,
removeViewBox: false,
},
},
},
],
};

const DefaultSVGRConfig: SVGRConfig = {
prettier: false,
svgo: true,
svgoConfig: DefaultSVGOConfig,
titleProp: true,
};
```

## Related links

- https://github.com/facebook/docusaurus/issues/8297
- https://github.com/facebook/docusaurus/issues/10636
- https://github.com/facebook/docusaurus/pull/10205
- https://github.com/facebook/docusaurus/pull/10211
- https://github.com/facebook/docusaurus/pull/10677

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.