exercism / exercism/javascript

Windowing System: Improvement Ideas

オープン
#1,600 コメント 4 件 リアクション 0 件 担当者 1 名 @SleeplessByte が担当を希望しています GitHub で見る
discussion :speech_balloon:
主要言語
JavaScript
スター
652
フォーク
657
平均マージ
19時間 37分
マージ済み PR(30日)
6

説明

After seeing a couple of solutions to "Windowing System" during mentoring, I think the exercise could need some changes to better achieve it's learning objectives.

* For `Position` and `Size`, the constructor and the method have the same implementation. I saw a solution that used the method in the constructor which is not a very typical example.
* There is no reason to use the methods to update values so students often just set the property values directly.
* The calculation for the window resize and move is rather involved which does not add value for the actual learning objectives but it seems students spend quite some time finding creative solutions there, e.g.
![image](https://user-images.githubusercontent.com/12543047/147859416-62818b06-71c5-4558-ba1e-d08cbda753d8.png)

Some ideas how to improve the exercise:
* Maybe we should expect some/all properties to be marked as private with the underscore to discourage the direct assignment. That might also make it easier to pick up unwanted code with the analyzer later. (Not sure how to best test in this case though. Either the test disrespects the underscore which is not a good example or the test needs to fall back on some user-implemented serialization function. But if that function is wrong all the tests will fail which is also annoying as everything else the user did could be correct.)
* The methods on `Position` and `Size` could change the values by some amount instead of just setting a value. That would make them distinct from the constructor. (Probably only needed if we stick with "public properties".)
* Simplify the window resize/move method e.g. by saying some lower bound is always respected

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。