Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions for encoding
- Ngôn ngữ chính
- C#
- Star
- 427
- Fork
- 383
- Merge trung bình
- 2 ngày 2 giờ
- Pull request đã merge (30 ngày)
- 5
Mô tả
On the Hyper-optimized Telemetry exercise, the instructions specify a table of ranges and target types for determining which type should be used when converting a long to the smallest integral type. Of particular interest in this issue is the range 0 - 65535 which should be represented with a `ushort`:

However, two unit tests are not following this specification. First one is `ToBuffer_upper_short`:

Since the supplied value 32767 is between 0 and 65353, this should be an unsigned short. Specifically `0x2, 0xff, 0x7f`.
The second unit tests not following the instructions is `ToBuffer_Zero`. It has the exact same problem, expecting 0 to be a signed short, while the instructions specify that it should be unsigned.

Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Đánh giá
Issue này chưa được đánh giá.