exercism / exercism/csharp

Hyper-optimized Telemetry: Two unit tests are not following specifications in instructions for encoding

Aperta
#1,795 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C#
Stelle
427
Fork
383
Merge medio
2g 2h
PR unite (30g)
5

Descrizione

On the Hyper-optimized Telemetry exercise, the instructions specify a table of ranges and target types for determining which type should be used when converting a long to the smallest integral type. Of particular interest in this issue is the range 0 - 65535 which should be represented with a `ushort`:

![image](https://user-images.githubusercontent.com/28660369/139478375-967596dd-a479-4031-b0a0-9b90f0d06eac.png)

However, two unit tests are not following this specification. First one is `ToBuffer_upper_short`:

![image](https://user-images.githubusercontent.com/28660369/139478743-db560855-f2bb-4d9b-b74d-15d41bcd9cb7.png)
Since the supplied value 32767 is between 0 and 65353, this should be an unsigned short. Specifically `0x2, 0xff, 0x7f`.

The second unit tests not following the instructions is `ToBuffer_Zero`. It has the exact same problem, expecting 0 to be a signed short, while the instructions specify that it should be unsigned.
![image](https://user-images.githubusercontent.com/28660369/139479316-b28b4e5a-f3f6-4e2f-8bc4-abd8072bbb4e.png)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.