ember-cli / ember-cli/ember-cli-htmlbars

Implements RFC 496 Incorrectly

Aperta
#713 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
77
Fork
65
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

ember-cli-htmlbars [configures](https://github.com/ember-cli/ember-cli-htmlbars/blob/faa39dbe53c55ba8e4cccbc2340336a69fbf7e45/lib/utils.js#L19):

```js
import { precompileTemplate } from '@ember/template-compilation'
```

to mean both `createTemplateFactory` and the wire format compilation. But that contradicts the RFC, which says that `precompileTemplate` is supposed to only produce the wire format.

The thing that's being implemented here is really `compile`, not `precompile`. `compile` is the one that automatically includes both steps.

The RFC muddies these waters by implying that `compile` would be for runtime compilation vs build-time compilation, but even if that is a true distinction we want to maintain, then we still need something that means "both steps, but at build time".

I would argue that `precompile` already means that in practice because of how it's implemented, and we could amend the RFC to make that clear.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.