ember-cli / ember-cli/ember-cli-htmlbars
Implements RFC 496 Incorrectly
- Vorherrschende Sprache
- JavaScript
- Sterne
- 77
- Forks
- 65
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
ember-cli-htmlbars [configures](https://github.com/ember-cli/ember-cli-htmlbars/blob/faa39dbe53c55ba8e4cccbc2340336a69fbf7e45/lib/utils.js#L19):
```js
import { precompileTemplate } from '@ember/template-compilation'
```
to mean both `createTemplateFactory` and the wire format compilation. But that contradicts the RFC, which says that `precompileTemplate` is supposed to only produce the wire format.
The thing that's being implemented here is really `compile`, not `precompile`. `compile` is the one that automatically includes both steps.
The RFC muddies these waters by implying that `compile` would be for runtime compilation vs build-time compilation, but even if that is a true distinction we want to maintain, then we still need something that means "both steps, but at build time".
I would argue that `precompile` already means that in practice because of how it's implemented, and we could amend the RFC to make that clear.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Bewertung
Dieses Issue wurde noch nicht bewertet.