ember-cli / ember-cli/ember-cli-htmlbars

Implements RFC 496 Incorrectly

Ouverte
#713 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
77
Forks
65
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

ember-cli-htmlbars [configures](https://github.com/ember-cli/ember-cli-htmlbars/blob/faa39dbe53c55ba8e4cccbc2340336a69fbf7e45/lib/utils.js#L19):

```js
import { precompileTemplate } from '@ember/template-compilation'
```

to mean both `createTemplateFactory` and the wire format compilation. But that contradicts the RFC, which says that `precompileTemplate` is supposed to only produce the wire format.

The thing that's being implemented here is really `compile`, not `precompile`. `compile` is the one that automatically includes both steps.

The RFC muddies these waters by implying that `compile` would be for runtime compilation vs build-time compilation, but even if that is a true distinction we want to maintain, then we still need something that means "both steps, but at build time".

I would argue that `precompile` already means that in practice because of how it's implemented, and we could amend the RFC to make that clear.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start with lib/utils.js at the linked configuration and read RFC 496 alongside the current meanings of precompileTemplate and compile. Determine whether the required change is in the implementation, the RFC, or both; the issue is complete only when the naming and behavior agree with the resolved definition.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript
Domaine
build-system
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.