elementary / elementary/code

"Save Duplicate" button does not work after unmounting source device

オープン
#1,818 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Vala
スター
521
フォーク
118
平均マージ
1日 8時間
マージ済み PR(30日)
14

説明

### What Happened?

While operating Code with "Save files when changed" preference off, a document was loaded from an unmountable source (USB stick). Some changes were made and then the source device unmounted before saving. Code showed a dialog with "Ignore" and "Save Duplicate" buttons. Pressing the latter just resulted in the dialog being shown again.

The only way to save the changes was to duplicate the tab into a new document and save that.

### Steps to Reproduce

1. Turn off "Save files when changed"
2. Open a document on an unmountable device
3. Make some changes
4. Unmount the device
5. Observe dialog and effect of pressing "Save Duplicate"

### Expected Behavior

Pressing "Save Duplicate" allows the changed document to be saved elsewhere.

### OS Version

8.x (Circe)

### OS Architecture

amd64 (on most hardwares)

### Session Type

Secure Session (Wayland, This is the default)

### Software Version

Latest Release

### Log Output

```shell
** (io.elementary.code:5576): WARNING **: 10:44:40.136: Document.vala:1356: Folder containing the file was unmounted

** (io.elementary.code:5576): CRITICAL **: 10:46:40.346: scratch_services_document_save_as_co: assertion '!locked && is_saving' failed
```

### Hardware Info

_No response_

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with Document.vala around line 1356, where the unmounted folder warning is logged, and trace the Save Duplicate path to the scratch_services_document_save_as_co assertion in the report. Reproduce the unmounted-device workflow and verify that Save Duplicate allows the changed document to be saved elsewhere without showing the dialog again.

索引モデルが issue の本文から書いたものです。

評価

領域
desktop
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
65/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。