elementary / elementary/code

"Save Duplicate" button does not work after unmounting source device

Aperta
#1,818 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Vala
Stelle
521
Fork
118
Merge medio
1g 8h
PR unite (30g)
14

Descrizione

### What Happened?

While operating Code with "Save files when changed" preference off, a document was loaded from an unmountable source (USB stick). Some changes were made and then the source device unmounted before saving. Code showed a dialog with "Ignore" and "Save Duplicate" buttons. Pressing the latter just resulted in the dialog being shown again.

The only way to save the changes was to duplicate the tab into a new document and save that.

### Steps to Reproduce

1. Turn off "Save files when changed"
2. Open a document on an unmountable device
3. Make some changes
4. Unmount the device
5. Observe dialog and effect of pressing "Save Duplicate"

### Expected Behavior

Pressing "Save Duplicate" allows the changed document to be saved elsewhere.

### OS Version

8.x (Circe)

### OS Architecture

amd64 (on most hardwares)

### Session Type

Secure Session (Wayland, This is the default)

### Software Version

Latest Release

### Log Output

```shell
** (io.elementary.code:5576): WARNING **: 10:44:40.136: Document.vala:1356: Folder containing the file was unmounted

** (io.elementary.code:5576): CRITICAL **: 10:46:40.346: scratch_services_document_save_as_co: assertion '!locked && is_saving' failed
```

### Hardware Info

_No response_

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with Document.vala around line 1356, where the unmounted folder warning is logged, and trace the Save Duplicate path to the scratch_services_document_save_as_co assertion in the report. Reproduce the unmounted-device workflow and verify that Save Duplicate allows the changed document to be saved elsewhere without showing the dialog again.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Ambito
desktop
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
65/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.