Formatting of conditional expressions

Open

#2,307 opened on Jun 15, 2018 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: java
Domain: tooling

Research direction

Use the issue's multiline conditional-expression examples as the expected behavior, then locate the formatter entry point for conditional expressions in the Xtext codebase. Add regression coverage for the reported alignment and verify the formatter output against the chosen expected layout.

Written by the indexing model from the issue text.

Description

The formatting of conditional expressions produces confusing results when the expression is broken into multiple lines.

One example:

                    return resolve(element.referenceType, if (project_type != ProjectType.PROTOBUF)
                        element.referenceType.mainProjectType
                    else
                        project_type)

Here, it is confusing that the else is aligned with the return rather than the if.

I would expect something like:

                    return resolve(element.referenceType, if (project_type != ProjectType.PROTOBUF)
                                                              element.referenceType.mainProjectType
                                                          else
                                                              project_type)

or, in this case maybe even better:

                    return resolve(element.referenceType, 
                                   if (project_type != ProjectType.PROTOBUF)
                                       element.referenceType.mainProjectType
                                   else
                                       project_type
                                  )

Dominant language: Java
Stars: 831
Forks: 330
Avg merge: 3d 7h
Merged PRs (30d): 12

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug] [Connector-V2] [Http] A streaming Http source never completes a checkpoint: poll_interval_millis is waited out holding the checkpoint lock Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

apache/seatunnel#12411 · Opened Sep 20, 2026
wafv2: TagResource/UntagResource don't enforce the 50-tag limit or key/value length limits Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

floci-io/floci#4035 · Opened Sep 20, 2026
[Bug]: 26.3 Missing directional_particles in ConsumeEffect Open

bug needs triage

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

Minestom/Minestom#3375 · Opened Sep 20, 2026
The `grepIn` javadoc example never matches real XMIR, so a user who copies it silently gets no optimization Open

Difficulty 1/5 Under an hour Newbie friendliness 94/100

objectionary/hone-maven-plugin#1061 · Opened Sep 20, 2026
Store the original domain event in the Namastack outbox Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

spring-projects/spring-modulith#1895 · Opened Sep 20, 2026

More Java issues