IdeContentProposalAcceptor class does not calculate priorities the same as the ConfigurableCompletionProposal class
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- java
- Domain
- developer-experience
Research direction
Start in org.eclipse.xtext.ide/src/org/eclipse/xtext/ide/editor/contentassist/IdeContentProposalAcceptor.java at the priority comparison near line 70, then compare it with ConfigurableCompletionProposal. Verify how lower priority values are ordered in Eclipse and IDE/LSP proposals, and check whether existing content-assist tests cover this difference. Done means the ordering is consistent or the intended distinction is explicitly preserved with regression coverage.
Written by the indexing model from the issue text.
Description
I am currently building a language server for my DSLs and while working on content assist, I noticed that my LSP proposals are sorted the other way around then my Eclipse proposals.
It seems that in Eclipse lower priority means further up in the list, while in IDE/LSP lower priority means further down in the list.
I subclassed IdeContentProposalAcceptor and switched the following statement around:
I changed int prioResult = p2.getKey().compareTo(p1.getKey()); to int prioResult = p1.getKey().compareTo(p2.getKey());.
Is this difference in behaviour intended or can that be changed?
- Dominant language
- Java
- Stars
- 831
- Forks
- 330
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 12
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eclipse-xtext/xtext
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
eclipse-xtext/xtext#3668 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
eclipse-xtext/xtext#3797 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
eclipse-xtext/xtext#3796 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 68/100
eclipse-xtext/xtext#3795 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
eclipse-xtext/xtext#3788 · 2 comments ·
All issues in eclipse-xtext/xtext
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
objectionary/hone-maven-plugin#1061 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
spring-projects/spring-modulith#1895 ·